Clear failed callbacks earlier #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failures look unrelated to the changes here. |
|
Hi @nedgar , Yes, build failure is not related to this change. I will first fix build before merging this PR. Thank you once again. |
|
Merged. Thank you @nedgar . |
|
Great, thanks @anilmaurya! |
|
@anilmaurya Any chance of a |
|
Yes, I will release |
|
@ajkerr Released |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #599.
This clears the failed callbacks (at the start of
Event#_fire) for all the event's transitions, not just the selected one, sincefailed_callbackscollects failures from all transitions. In particular, this is needed to avoid propagating past failures when no transition is applicable.