Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test for rails 5.2 #624

Merged
merged 2 commits into from May 7, 2019
Merged

Ensure test for rails 5.2 #624

merged 2 commits into from May 7, 2019

Conversation

waghanza
Copy link
Contributor

@waghanza waghanza commented May 6, 2019

Hi,

This PR resolve #623

It add testing for Rails 5.2 on CI

Regards,

PS : May I suggest to fix constraint to dynamoid ~> 1.3 for rails 5.0 and 5.1
Support was added from this version @see https://github.com/Dynamoid/Dynamoid/blob/master/CHANGELOG.md#130

@anilmaurya anilmaurya merged commit d3b287d into aasm:master May 7, 2019
@anilmaurya
Copy link
Member

Thank you @waghanza for contributing. I appreciate your help 👍
Regarding fix constraint to dynamoid ~> 1.3 for rails 5.0 and 5.1, please raise a separate PR for it.

@waghanza waghanza deleted the test/rails_5.2 branch May 7, 2019 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails 5.2 not tested
2 participants