remove force to C++17 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If Ok then I can also create a backport request to Leia. |
|
Fine by me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think this not needed and breaks the Raspberry build of the addon?
Was added by this commit b30d1c2#diff-af3b638bc2a3e6c650974192a53c7291R33 where also a
stdc++fswas on libs (whould make sense then). But was removed on d6e2b49#diff-af3b638bc2a3e6c650974192a53c7291L21 and seen nothing in code where C++17 is needed.By remove the Raspberry build was fixed.
Not sure if needed for future, but thought to ask with it.