Service labels #10
Service labels #10
Conversation
Token auth
Return Marathon Application Service Labels as Spring Cloud Service In…
|
Nice feature. |
|
Yes, of course. I am working on another complimentary feature to locate services using a regular expression or wild card. Then applying a ribbon filter over ServiceInstance meta-data makes a lot more sense, as each service located could have a different set of labels. This kind of thing really helps when applying rolling updates. I'll keep working on this branch & will update the documentation & example application. |
…ervice labels. Note: depends on 0.3.1-SNAPSHOT of the Marathon Client (to support secrets returned in App.env)
|
Note: depends upon com.mesosphere:marathon-client:0.3.1-SNAPSHOT (to support DC/OS secrets that are returned in App.env) |
| GetAppsResponse getApps() throws MarathonException; | ||
|
|
||
| @RequestLine("GET /v2/apps") | ||
| GetAppsResponse getApps(@QueryMap Map<String, String> queryMap) throws MarathonException; |
There was a problem hiding this comment.
Added a new method to support passing query parameters to /v2/apps
e.g.
/v2/apps?id=myServiceName
Submitted a PR to mesosphere/marathon-client for this change:
https://github.com/mesosphere/marathon-client/pull/44
| @@ -22,6 +22,8 @@ allprojects { | |||
|
|
|||
| repositories { | |||
| jcenter() | |||
| mavenLocal() | |||
There was a problem hiding this comment.
This is temporary. Have built com.mesosphere:marathon-client:0.3.1-SNAPSHOT locally.
There was a problem hiding this comment.
I think we could not wait until new Marathon lib version will be released, cause you've already patched Marathon client. So, remove that for passing travis tests and I merge your PR.
| @@ -40,7 +42,7 @@ allprojects { | |||
|
|
|||
| dependencies { | |||
| dependency 'org.projectlombok:lombok:1.16.8' | |||
| dependency 'com.mesosphere:marathon-client:0.3.0' | |||
| dependency 'com.mesosphere:marathon-client:0.3.1-SNAPSHOT' | |||
There was a problem hiding this comment.
Using com.mesosphere:marathon-client:0.3.1-SNAPSHOT (built locally) to support DC/OS secrets in App.env
There was a problem hiding this comment.
See my another comment about maven local.
…rs by Marathon Service Labels
Service labels
|
There are some troubles with PR after merging. Could you fix the problem? |
|
Anyway, I've eliminated DCOS part, reverted marathon client lib version to 0.3.0 and fixed build. Thank for you pull request. If you want DCOS part to comeback, please, merge with master and make new pull request with changes that will pass CI build. |
|
Do you have twitter? I wanna mention you in tweet about new version of starter. |
|
Yes. My twitter handle is @tegatai |
|
I'm talking with the chaps at Mesosphere about getting my PR for QueryParms merged in and to have them release their 0.3.1 version. We have a commercial relationship with them, so I am hopeful this will happen soon. When that is done I'll be able to re-commit the changes for DCOS authentication. In the meantime, I've created my own artifacts for marathon-client:0.3.1 & spring-cloud-marathon (with DCOS authentication) to keep our internal development moving forward. |
|
Ok, that's great! |
|
My changes to marathon-client have been accepted & merged into their master. Waiting on Mesosphere for a release of 0.3.1. |
|
Mesosphere are preparing to release marathon-client 0.5.0, which contains my changes. When it hits maven central I'll open a PR to merge in support for DCOS authentication. |
|
Ok, it is great news. Will be waiting for changes) |
Adjusted MarathonDiscoveryClient to return Marathon Application Labels (a map of key/value pairs) as the Spring Cloud Discovery ServiceInstance meta-data (also a map of key/value pairs). This will facilitate applying Predicate Filters using Ribbon e.g. "fetch all service instances with the following key/value combinations". This enables us to also announce service capabilities.