Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of CSV module from sqlmain.py #19

Closed
Aathish04 opened this issue Jun 19, 2020 · 0 comments · Fixed by #25
Closed

Remove usage of CSV module from sqlmain.py #19

Aathish04 opened this issue Jun 19, 2020 · 0 comments · Fixed by #25
Assignees
Labels
enhancement New feature or request

Comments

@Aathish04
Copy link
Owner

Aathish04 commented Jun 19, 2020

def parseCSV(fp): #Why can't you use CSVManager.list_od_from_csv for this?

For the sake of code cleanliness, it is better to have a single module handling all of the CSV related issues. sqlmain.py should not have any csv related code at all.

The function defined at:

def parseCSV(fp): #Why can't you use CSVManager.list_od_from_csv for this?

Is the same as the function defined at:

def list_od_from_csv(self,datafile=None):

There is absolutely no need to repeat code again and again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants