Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/new frontend #110

Merged
merged 11 commits into from
Feb 16, 2022
Merged

Feature/new frontend #110

merged 11 commits into from
Feb 16, 2022

Conversation

MulvadT
Copy link
Contributor

@MulvadT MulvadT commented Feb 3, 2022

No description provided.

@MulvadT
feat: Frontend step process (NOT DONE)
97207b8 
Making changes for new frontend 
Still missing the rest of handler
@MulvadT
feat: new logo + signup pagefix
342b224 
Not done with all the handlers, temps are there to load all the pages, missing such that the flow are setup correct between the pages, and only load the correct one.
@MulvadT
feat: pick team later in the process and other things
1c04eaf
@MulvadT
feat: scenario information on team pages
74ad361
@MulvadT
feat: accept GDPR in signup
21b6231
@MulvadT
fix: get vpn config from game page
8607dbb
@MulvadT MulvadT requested a review from rasmim February 3, 2022 13:16
@MulvadT MulvadT self-assigned this Feb 3, 2022
@MulvadT MulvadT added this to In progress in End of Year - DefAtt via automation Feb 3, 2022
@gitguardian
Copy link

gitguardian bot commented Feb 3, 2022 •
edited
Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Slack Webhook URL 342b224 config.yml 23:07 February 1st, 2022 View secret
GitLab Token 342b224 config.yml 23:07 February 1st, 2022 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

@MulvadT MulvadT linked an issue Feb 3, 2022 that may be closed by this pull request
Add senario information to landing page #95
Closed
3 tasks
@MulvadT
fix(Frontend): timer uses event duration
96138a8
@MulvadT
fix(Frontend): Showing the networks on team page
2a85617 
Getting the networks from the event and showing them in the team scenario
rasmim
rasmim reviewed Feb 7, 2022
View reviewed changes
frontend/privateOLD/wireguard.conf.tmpl Outdated
@@ -0,0 +1,11 @@
[Interface]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this used in the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not used as all files in privateOLD, but wireguard.conf.tmpl is also in the new folder

The file are used here

defatt/frontend/handler.go

Line 401 in 2a85617

tmpl := textTemplate.Must(textTemplate.ParseFiles(templatesBasePath + "wireguard.conf" + templatesExt))

Used to make the VPN config for the user.

rasmim
rasmim reviewed Feb 7, 2022
View reviewed changes
database/gameUser.go
@@ -15,16 +15,18 @@ type Team string
const (
RedTeam Team = "red"
BlueTeam Team = "blue"
NoTeam Team = "no"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this value used in the code?

rasmim
rasmim reviewed Feb 7, 2022
View reviewed changes
database/gameUser.go
@@ -37,12 +39,37 @@ func AddUser(ctx context.Context, username, email, password, gameID string, team
user.Team = team
user.CreatedAt = time.Now()
user.GameID = gameID
user.JoinedGame = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's discuss this part, I do not get why we need this line.

rasmim
rasmim reviewed Feb 7, 2022
View reviewed changes
Copy link
Member

@rasmim rasmim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things that we should discuss.

End of Year - DefAtt automation moved this from In progress to Waiting_manual_test Feb 15, 2022
@MulvadT MulvadT merged commit 8106bd7 into development Feb 16, 2022
End of Year - DefAtt automation moved this from Waiting_manual_test to Done Feb 16, 2022
@rasmim
Copy link
Member

rasmim commented Mar 22, 2022 •
edited
Loading

The interface has a bug in the RED WG configuration file. Sometimes it gets the correct IPs in the AllowedIP, other times is just getting an IP they should not. Check the attached photo configurations:

https://imgur.com/a/teo5MVL

Moreover, the timer has another bug. It displays a time for Red and a time for Blue users. It appears problem when multiple users are registering.

@MulvadT

@rasmim rasmim mentioned this pull request Apr 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasmim rasmim rasmim approved these changes

Assignees

@MulvadT MulvadT

Labels
None yet
Projects
End of Year - DefAtt
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add senario information to landing page
2 participants
@MulvadT @rasmim