Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YamlDotNet shouldn't export NRT attributes. #456

Closed
brian-reichle opened this issue Dec 5, 2019 · 0 comments · Fixed by #460
Closed

YamlDotNet shouldn't export NRT attributes. #456

brian-reichle opened this issue Dec 5, 2019 · 0 comments · Fixed by #460

Comments

@brian-reichle
Copy link

YamlDotNet defines NotNullWhenAttribute and MaybeNullWhenAttribute as public.

These really should be internal so that they don't introduce name conflicts when this package is consumed in conjunction with another that defines them.

The issue can be worked around with an alias, but shouldn't have to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix type conflicts when targeting frameworks without nullability attributes
1 participant
@brian-reichle