Fix type conflicts when targeting frameworks without nullability attributes #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure-complete package from NuGet.
|
I'm unsure why the build failed. It does not appear to have anything to do with my changes. |
|
Thanks for this. I will do a release today that includes this. |
|
Great! |
|
YamlDotNet 8.1.0 has just been uploaded to NuGet.org. It should be available in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current form, YamlDotNet produces type conflicts with other projects that target frameworks which do not include nullability attributes, but add them in other ways to allow full nullability support in the compiler. The issue typically displays as a warning during compilation that one or the other type was selected.
The issue is caused by YamlDotNet declaring the polyfill attributes in Portability.cs as
public, and not covering all frameworks in the preprocessor directives that guard them.This pull request removes YamlDotNet's own polyfill attributes, and references a compile-time NuGet packages which defines all nullability attributes and compiles them as internal attributes into targets which require them, preventing any conflicts with other projects. The package used (Nullable) is completely transparent to the end user, and does not incur any additional dependencies for consumers.
Fixes #456.