Add support for deserializing fields in addition to properties #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaubry
force-pushed
the
master
branch
2 times, most recently
from
be468bf
to
145477a
Compare
|
@aaubry, could this be considered for the next version of YamlDotNet? |
|
Apparently this PR got lost somehow and in the meantime serialization of fields was independently added to release 5.4.0. Can this be closed, or is there a feature here that is not provided by the current implementation ? |
aaubry
force-pushed
the
master
branch
2 times, most recently
from
d4fd04a
to
cb0768c
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made changes so that I can deserialize yaml to fields, which should address #117 "Serializing also fields and not just properties will make life easier". This is convenient for Unity objects with [SerializeField] members because Unity disallows using properties for these fields.
I'm not setup to test on platforms other than net46, so there may be issues on other platforms. I added a simple unit test. I'll attempt to execute the docker-based build/test soon when I have a chance to review how it works. I haven't done a pull request on a public repo before, so let me know if there is protocol I'm overlooking.
Thank you for publishing this library! It has been very useful to us.