YamlIgnore attributes are inherited #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source of this bug is the fact that IMemberInfo.GetCustomAttributes actually ignores it's "inherit" parameter. https://docs.microsoft.com/en-us/dotnet/api/system.reflection.memberinfo.getcustomattributes This addresses aaubry#271
|
This does not build on netstandard1.3 because |
|
I've implemented a workaround for netstandard1.3. If this workaround can't be used there's also the possibility of adding netstandard2.0 as a target for netstandard1.3 builds. There is some documentation that suggests this: https://github.com/dotnet/standard/blob/master/docs/versions.md#how-do-i-know-which-net-standard-version-i-should-target |
|
This looks good. I'd rather avoid changing the targets at this point because that could break other people's code. I have no way of knowing which target platforms are actually used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source of this bug is the fact that IMemberInfo.GetCustomAttributes actually ignores its "inherit" parameter.
https://docs.microsoft.com/en-us/dotnet/api/system.reflection.memberinfo.getcustomattributes
This addresses #271