Issue#601 Support for deserialization of interface types #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ir concrete types using the builder.AddTypeMapping<TInterface, TConcrete>() api.
…nly applies to DeserializerBuilder. Updated dictionaries to instance types as the static types caused concurrent unit tests to fail. Updated DefaultObjectFactory to use lazy loading to allow constructor initialization with type mappings.
|
This is related to issue #604 |
|
This looks really good. Thanks! |
|
This heature has been released in version 11.1.0. |
Thank you for the starting this project! I also noticed that your code coverage configuration needs to be updated so that it shouldn't count any other code than the main project. I will push another PR to address that unless you disagree. |
|
Sure. I wasn't aware that code coverage was even being measured, but of course it's better to make it accurate.
8 Apr 2021 17:54:49 dotlegacy ***@***.***>:
…> This looks really good. Thanks!
>
Thank you for the starting this project! I also noticed that your code coverage configuration needs to be updated so that it shouldn't count any other code than the main project. I will push another PR to address that unless you disagree.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub[#604 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAEZ5X45RQ6VVFPCPC77KGDTHXNVRANCNFSM42NSH3PA].
[data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEQAAABECAYAAAA4E5OyAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAoSURBVHic7cEBAQAAAIIg/69uSEABAAAAAAAAAAAAAAAAAAAAAACPBkiEAAHzeIrHAAAAAElFTkSuQmCC###24x24:true###][Tracking image][https://github.com/notifications/beacon/AAEZ5XYME7DYF6KKS7JV6EDTHXNVRA5CNFSM42NSH3PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGCROS3Y.gif]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ir concrete types using the builder.AddTypeMapping<TInterface, TConcrete>() api.
Welcome!
Thanks for your interest in contributing to this project. Any contribution will
be gladly accepted, provided that they are generally useful and follow the
conventions of the project.
Please create one pull request for each feature. This results in smaller pull requests that are easier to review and validate.
Avoid reformatting existing code unless you are making other changes to it.
usings is acceptable, if you made other changes to that file.Always add one or more unit tests that prove that the feature / fix you are submitting is working correctly.
Please describe the motivation behind the pull request. Explain what was the problem / requirement. Unless the implementation is self-explanatory, also describe the solution.
Follow the project's coding conventions