Add basic support to populate pre-existing C# objects when deserializing #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 4, 2022 15:29
Add IDeserializer.PopulateObject() APIs Add currentValue parameter to INodeDeserializers and IValueDeserializers Add checks to only create a new instance if currentValue is empty Add ways to allow the user to configure population of pre-existing collections: DeserializerBuilder.WithCollectionPopulationOptions() Note: Pre-existing collection _items_ do _not_ get populated. Pre-existing collections can be re-used though, see DeserializerBuilder.WithCollectionPopulationOptions() Todo: Allow to populate pre-existing collection items. This needs some refactoring of the way the Array-, Collection- and DictionaryNodeDeserializer work.
Closed
aaubry
force-pushed
the
master
branch
8 times, most recently
from
a0f8359
to
78b1ab3
Compare
|
This PR is really old, with a lot of merge conflicts. I'm going to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
IDeserializer.PopulateObject()APIsAdd
currentValueparameter toINodeDeserializers andIValueDeserializersAdd checks to only create a new instance if
currentValueis emptyAdd ways to allow the user to configure population of pre-existing collections:
DeserializerBuilder.WithCollectionPopulationOptions()Note: Pre-existing collection items do not get populated. Pre-existing collections can be re-used though, see
DeserializerBuilder.WithCollectionPopulationOptions()Todo: Allow to populate pre-existing collection items. This needs some refactoring of the way the
Array-,Collection- andDictionaryNodeDeserializerwork.#130