New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent line endings #720
Fix inconsistent line endings #720
Conversation
I'm thinking a potentially better solution to this would be using
I'm going off of memory here, so it may be incorrect values. But then, in theory, it'll be correct regardless of the platform (Linux aka Docker/Windows/etc) it is checked out on. |
Sure. Happy to add the adjusted |
This change broke the build - https://ci.appveyor.com/project/aaubry/yamldotnet/builds/44921032 You need to be very careful with line endings because Linux doesn't expect |
The the PR itself was building correctly - https://ci.appveyor.com/project/aaubry/yamldotnet/builds/44817924. |
The run.sh file hasn't been modified. I guess it's .gitattributes that is causing the problem. I'm not familiar with this file. I always configure git to never modify my line endings. @EdwardCooke do you have an idea of how to fix this? |
I'll get it fixed. Not sure why it would have failed either. gitattribes for .sh files was added a while ago. |
Got it fixed. . was overriding the *.sh. |
The . is going to cause additional problems I think. It looks like it may break some of the binary files, like yamldotnet.png. I think I'll remove the . and change it to *.cs to fix it for real. One second. |
And when I just pushed up my changes to git attributes it pushed up the broken files, argh. Stupid gitattributes. Lesson learned there, don't do .. |
This feature has been released in version 12.0.2. |
Update the line endings across the project to be consistent.
Motivation
Some tools complain when dealing with mixed line endings. The project currently has a mix of Windows
\r\n
and Unix style\n
.