Fixed DateTime serialization with JSON using single quotes #768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #587
When using
JsonCompatible
we will now register aDateTimeConverter
.If the user is adding a
DateTimeConverter
object before callingJsonCompatible
on the serializer, this call will fail. If the user is adding some other, custom,DateTime
converter, the one added byJsonCompatible
will take priority, and the users converter will be skipped.If the user wants to specify their own
DateTimeConverter
or some otherDateTime
converter object, they will need to do it after callingJsonCompatible
.If they are passing their own
DateTimeConverter
, they can now specify the optional constructor argument,doubleQuotes
, so it will dish out valid JSON.