Add support for including types defined in another assembly in static code generation #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly in static code generation.
EdwardCooke
reviewed
Oct 5, 2023
|
I like this approach, this is nice. The only comment is about the null propagation compiler warning. Once that's resolved, I'll merge this in. |
|
Glad that you like it. When do you plan the next release including this feature ? |
|
In about 2 minutes, have to let the pipelines finish :) |
|
This feature has been released in version 13.5.0. |
|
It takes a couple of minutes for NuGet to approve the package but it will be there momentarily. |
|
Sure. Thanks for accepting the feature/PR. |
|
@EdwardCooke there is one change missing which I accidently did not commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a second constructor to the
YamlSerializableAttributeto allow static code generation for types defined in another assembly.Fixes issue #851