Handle blank lines in Yaml.Text()
#887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
commented
Jan 7, 2024
| @@ -252,7 +252,7 @@ public void DeserializeWithGapsBetweenKeys() | |||
| { | |||
| var yamlReader = new StringReader(@"Text: > | |||
| Some Text. | |||
|
|
|||
There was a problem hiding this comment.
whitespace-only changes in this file are essentially end-to-end tests of Yaml.Text() 😄
dougbu
commented
Jan 7, 2024
|
|
||
| namespace YamlDotNet.Test | ||
| { | ||
| public class YamlTests |
There was a problem hiding this comment.
no, this test class does not cover the Yaml test helper class comprehensively. it covers what I changed in Yaml.Text() however
- see aaubry#886 - transform blank lines to `string.Empty` - remove all trailing whitespace from lines - if trailing whitespace is significant in a future test, YAML files can be added - `throw new ArgumentException(...)` if a line is insufficiently indented - should be easier to fix test than with previous `ArgumentOutOfRangeException` for this case - add tests
dougbu
force-pushed
the
dougbu/blank.lines.886
branch
from
e34c4f7
to
c04446e
Compare
|
This feature has been released in version 15.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yaml.Text(...)fumbles without trailing whitespace #886string.Emptythrow new ArgumentException(...)if a line is insufficiently indentedArgumentOutOfRangeExceptionfor this case