Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete function. #38

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Add delete function. #38

merged 1 commit into from
Dec 16, 2023

Conversation

aaugustin
Copy link
Owner

It could be implemented with the ORM. However, we have everything needed to implement it with raw SQL; it's simpler, especially when it comes to exception handling; and there's no need to pull the big guns here.

Fix #37.

It could be implemented with the ORM. However, we have everything needed
to implement it with raw SQL; it's simpler, especially when it comes to
exception handling; and there's no need to pull the big guns here.
@aaugustin aaugustin mentioned this pull request Aug 25, 2023
Copy link

@fledman fledman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

deletion also serves to manually reset the sequence, if anyone needs to do that programmatically

@aaugustin aaugustin merged commit 14fe696 into main Dec 16, 2023
@aaugustin aaugustin deleted the delete branch December 16, 2023 20:19
@aaugustin
Copy link
Owner Author

Just noticed that I forgot to merge this... Now it's done!

@aaugustin
Copy link
Owner Author

And available on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dropping old sequences
2 participants