Improve DRY in tests.

aaugustin · May 1, 2019 · db6fe88 · db6fe88
1 parent 86f1864
commit db6fe88
Showing 1 changed file with 9 additions and 25 deletions.
diff --git a/sesame/test_backends.py b/sesame/test_backends.py
@@ -18,7 +18,10 @@ def setUp(self):
         self.backend = ModelBackend()
 
         User = get_user_model()
-        self.user = User.objects.create(username='john')
+        self.user = User.objects.create(
+            username='john',
+            last_login=timezone.now() - datetime.timedelta(3600),
+        )
 
         self.log = io.StringIO()
         self.handler = logging.StreamHandler(self.log)
@@ -95,36 +98,17 @@ def test_token_without_timestamp(self):
 @override_settings(SESAME_ONE_TIME=True)
 class TestModelBackendWithOneTime(TestModelBackend):
 
-    def setUp(self):
-        super(TestModelBackendWithOneTime, self).setUp()
-
-        User = get_user_model()
-        self.login_user = User.objects.create_user(
-            username='jane',
-            password='doe',
-            last_login=timezone.now() - datetime.timedelta(1),
-        )
-
-    def test_authenticate(self):
-        token = self.backend.create_token(self.login_user)
-        user = self.backend.authenticate(request=None, url_auth_token=token)
-        self.assertEqual(user, self.login_user)
-
-    def test_valid_token(self):
-        token = self.backend.create_token(self.login_user)
-        user = self.backend.parse_token(token)
-        self.assertEqual(user, self.login_user)
-        self.assertIn("Valid token for user jane", self.get_log())
-
-    def test_token_last_login_none(self):
+    def test_no_last_login(self):
+        self.user.last_login = None
+        self.user.save()
         token = self.backend.create_token(self.user)
         user = self.backend.parse_token(token)
         self.assertEqual(user, self.user)
         self.assertIn("Valid token for user john", self.get_log())
 
-    def test_password_change(self):
+    def test_last_login_change(self):
         token = self.backend.create_token(self.user)
-        self.user.last_login = timezone.now()
+        self.user.last_login = timezone.now() - datetime.timedelta(1800)
         self.user.save()
         user = self.backend.parse_token(token)
         self.assertEqual(user, None)