skip User.EMAIL_FIELD check if not invalidating on email change

aaugustin · Aug 9, 2023 · eb312b1 · eb312b1
1 parent b08beec
commit eb312b1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/src/sesame/settings.py b/src/sesame/settings.py
@@ -110,14 +110,15 @@ def check():
         )
 
     global INVALIDATE_ON_EMAIL_CHANGE
-    User = get_user_model()
-    try:
-        User._meta.get_field(User.get_email_field_name())
-    except FieldDoesNotExist:
-        raise ImproperlyConfigured(
-            "invalid configuration: set User.EMAIL_FIELD correctly "
-            "or set SESAME_INVALIDATE_ON_EMAIL_CHANGE to False"
-        )
+    if INVALIDATE_ON_EMAIL_CHANGE:
+        User = get_user_model()
+        try:
+            User._meta.get_field(User.get_email_field_name())
+        except FieldDoesNotExist:
+            raise ImproperlyConfigured(
+                "invalid configuration: set User.EMAIL_FIELD correctly "
+                "or set SESAME_INVALIDATE_ON_EMAIL_CHANGE to False"
+            )
 
 
 check()

diff --git a/tests/test_settings.py b/tests/test_settings.py
@@ -25,7 +25,7 @@ def test_insecure_configuration(self):
         )
 
     @override_settings(
-        SESAME_INVALIDATE_ON_EMAIL_CHANGE=False,
+        SESAME_INVALIDATE_ON_EMAIL_CHANGE=True,
         AUTH_USER_MODEL="tests.StrUser",
     )
     def test_invalid_configuration(self):