-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokens v2 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes room for adding v2.
* Shorter. * Better security design. * No private APIs (django.utils.crypto). It isn't used yet.
This was referenced Jun 5, 2020
Closed
aaugustin
force-pushed
the
tokens-v2
branch
9 times, most recently
from
June 6, 2020 07:12
067ed84
to
7a0fbec
Compare
* Shorter. * Better security design. * No private APIs (django.utils.crypto). v1 tokens are still accepted for backwards-compatibility.
This would make tokens significantly longer. Tokens v1 are only kept for backwards compatibility anyway.
Review documentation generally. Remove documentation for ``SESAME_DIGEST`` and ``SESAME_ITERATIONS``. Using PBKDF2 in tokens v1 was a mistake anyway. If anyone is concerned, they should switch to tokens v2 and increase SIGNATURE_SIZE. Remove rst markup that isn't supported by GitHub.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.