Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mintToTreasury virtual so it can be overridden #726

Merged

Conversation

davidlaprade
Copy link
Contributor

This PR makes AToken's mintToTreasury function overridable.

Having this function be virtual will make AToken easier to extend, e.g. for grant-funded projects like the one I'm working on. It would also be consistent with the treatment of similar functions like AToken's mint, which is virtual:

function mint(
address caller,
address onBehalfOf,
uint256 amount,
uint256 index
) external virtual override onlyPool returns (bool) {

Copy link
Contributor

@miguelmtzinf miguelmtzinf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me

@miguelmtzinf miguelmtzinf merged commit 005b3ec into aave:feat/3.0.1 Nov 3, 2022
@davidlaprade
Copy link
Contributor Author

Thanks @miguelmtzinf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants