Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo that gives error while building #48

Closed
wants to merge 1 commit into from

Conversation

PaulSimode
Copy link

@PaulSimode PaulSimode commented Sep 6, 2023

There seems to be a typing error in helpers/index.ts, line 17.

I believe the correct path is "../tasks/market-registry/market-registry_add" instead of "../tasks/market-registry/market-registry:add". Changing this allowed me to continue with building.

The corresponding issue is #49.

@height
Copy link

height bot commented Sep 6, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@miguelmtzinf
Copy link
Contributor

miguelmtzinf commented Feb 27, 2024

The file it's actually named market-registry:add. However, will rename to market-registry-add for consistency. Thanks @PaulSimode
Done in #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants