fix: use SafeERC20 #176
fix: use SafeERC20 #176
Conversation
|
This pull request has been linked to 1 task:
|
|
Link T-12904 |
| @@ -3,12 +3,12 @@ pragma solidity ^0.8.10; | |||
|
|
|||
| import {DataTypes} from '@aave/core-v3/contracts/protocol/libraries/types/DataTypes.sol'; | |||
| import {FlashLoanSimpleReceiverBase} from '@aave/core-v3/contracts/flashloan/base/FlashLoanSimpleReceiverBase.sol'; | |||
| import {GPv2SafeERC20} from '@aave/core-v3/contracts/dependencies/gnosis/contracts/GPv2SafeERC20.sol'; | |||
There was a problem hiding this comment.
Let's keep using GPv2SafeERC20 for transfers, cause its more gas effective. So add SafeERC20 and use it only for safeApprove calls
|
Closes #174 |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
=======================================
Coverage 55.78% 55.78%
=======================================
Files 25 25
Lines 968 968
Branches 123 123
=======================================
Hits 540 540
Misses 428 428
☔ View full report in Codecov by Sentry. |
|
@aave/core-v3, which hasSafeERC20dependencysafeApproveinstead ofapprove