refactor: General Optimizations #80
Conversation
…-protocol into refactor/general-optimizations
…profile image URI setters to calldata.
…coveredAddress()`.
…ted with prettier.
…sible overflow cases.
|
The internal functions do not have natspec documentation |
contracts/core/LensHub.sol
Outdated
| @@ -892,7 +894,7 @@ contract LensHub is ILensHub, LensNFTBase, VersionedInitializable, LensMultiStat | |||
| _collectModuleWhitelisted, | |||
| _referenceModuleWhitelisted | |||
| ); | |||
| _profileById[vars.profileId].pubCount++; | |||
| ++_profileById[vars.profileId].pubCount; | |||
There was a problem hiding this comment.
Could this increment be done in line 891?
There was a problem hiding this comment.
No because this introduces a vuln that allows the comment to point to itself.
There was a problem hiding this comment.
PublishingLogic::createComment performs external calls, so there might be a reentrancy that could overwrite the comment content and emit two different comments for the same publication id.
There was a problem hiding this comment.
Yeah will address this and then merge
There was a problem hiding this comment.
Addressed in 90d6c69!
…`LensPeriphery`, including the name used in the domain separator.
|
As for natspec in internals, I think keeping it in the externals and publics is fine, we don't want to overdo it with the comments imo-- especially because we cannot |
…d manually prevent self-referencing comments.
There was a problem hiding this comment.
I left a comment about renaming _shots to something more clear. I'll approve anyways and let @Zer0dot find a better name or just merge this
misc: Fix namespace resolve functions
This PR contains general optimizations and is being actively worked on.