Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label order not preserved #32

Closed
aazuspan opened this issue Nov 14, 2022 · 0 comments · Fixed by #35
Closed

Label order not preserved #32

aazuspan opened this issue Nov 14, 2022 · 0 comments · Fixed by #35
Labels
bug Something isn't working

Comments

@aazuspan
Copy link
Owner

The order of time steps in the output plot should match the order provided in img_list. Instead it looks they're sorted alpha based on label_list. This only affects custom datasets because premade datasets use sequential year labels which (accidentally) get sorted correctly.

@aazuspan aazuspan added the bug Something isn't working label Nov 14, 2022
aazuspan added a commit that referenced this issue Nov 14, 2022
Earth Engine sorts FeatureCollection columns alphabetically, which
can lead to figures with incorrect label order. This fix re-sorts
the columns after sampling from Earth Engine to ensure the label
order matches the requested order. Also modifies the sampling test
data to prevent regression.
aazuspan added a commit that referenced this issue Nov 14, 2022
Earth Engine sorts FeatureCollection columns alphabetically, which
can lead to figures with incorrect label order. This fix re-sorts
the columns after sampling from Earth Engine to ensure the label
order matches the requested order. Also modifies the sampling test
data to prevent regression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant