Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate path parameter for saving to netcdf #67

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Conversation

aazuspan
Copy link
Owner

For simplicity, this deprecates the path parameter to the to_xarray methods. Instead, users can directly access the to_netcdf method in xarray.

@aazuspan aazuspan self-assigned this Jun 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #67 (4fdaec8) into main (5bcffe2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   97.42%   97.44%   +0.01%     
==========================================
  Files          20       20              
  Lines        1050     1055       +5     
==========================================
+ Hits         1023     1028       +5     
  Misses         27       27              
Impacted Files Coverage Δ
wxee/collection.py 100.00% <100.00%> (ø)
wxee/image.py 91.46% <100.00%> (+0.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aazuspan aazuspan merged commit 17f11e9 into main Jun 11, 2023
6 checks passed
@aazuspan aazuspan deleted the deprecate_netcdf branch June 11, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants