Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalized React Capstone Project for review #4

Merged
merged 65 commits into from
Jul 1, 2023
Merged

Finalized React Capstone Project for review #4

merged 65 commits into from
Jul 1, 2023

Conversation

ab-noori
Copy link
Owner

@ab-noori ab-noori commented Jul 1, 2023

React Capstone Project: finalized version for review

🌟Features:

  • - Project is created using CRA.
  • - The Coin Gecko API is used to fetch live cryptocurrency data.
  • - Currencies page is created and styled step by step in detail according to the project requirements.
  • - Currency details page is created and styled step by step in detail according to the project requirements.
  • - Data for both pages are retrieved from relevant API endpoints.
  • - The long currency numeric values are formatted using the Millify library.
  • - The Search field is added but it is not completed and needs to work it more.
  • - Header including Navbar is created and Link is used for navigating between pages.

🚀 Project Demo

Copy link

@Mihndim2020 Mihndim2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED!!! 🎉 🎉 🎉 🍾 🍾 🍾

Hi @ab-noori,

Good job !!!

To Highlight! 👏 🟢

✔️ Good commit messages
✔️ Descriptive Readme file
✔️ Clean and Organized code
✔️ Good job with UI
✔️ Good job with test coverage

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉 🎉 🍾 🍾 🍾

Congratulations-Memes-FEATURED

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack using this handle @Mihndim.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Copy link
Owner Author

@ab-noori ab-noori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mihndim2020 👋,
Thank you so much 🙏 for reviewing and approving my project🥰 .
Your nice feedback is appreciated 🙏.

thank-you-gif-22

@ab-noori ab-noori merged commit 2eae148 into main Jul 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants