Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix #345 #347

Merged
merged 1 commit into from
Dec 2, 2020
Merged

bug fix #345 #347

merged 1 commit into from
Dec 2, 2020

Conversation

carbon-wpa
Copy link
Contributor

No description provided.

@carbon-wpa
Copy link
Contributor Author

@jaibatrik I have created a fix for #345.

jaibatrik
jaibatrik approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jaibatrik jaibatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest some refactoring; can be done later probably.

@jaibatrik jaibatrik merged commit 3e99642 into abacritt:master Dec 2, 2020
@carbon-wpa
Copy link
Contributor Author

Great! I will do the refactoring, please give me your hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaibatrik jaibatrik jaibatrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carbon-wpa @jaibatrik