-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
power spectrum module optimization and parallelization #102
Conversation
…the (k,mu) counts
… calc_pk_from_deltak. Refactor handling of poles argument as numba workaround.
@boryanah Here are the changes we talked about. It's about half optimization and half refactoring. I tried to rename some things that were confusing to me, but let me know if I misunderstood anything. I also tried to cut down on the number of arguments and return values in some places. For example, I changed |
That looks great to me! The optimizations make sense (I am sorry I didn't implement the normalization one myself). The astropy table for the power spectrum with the meta data is great, and I think it's a good solution for outputting a single object that contains some useful information about the simulation. I think it makes sense why you got rid of some of the |
Yeah, that's exactly right about the |
Some optimization, parallelization, and Numba-fication of various parts of the power spectrum module. Benchmark scripts used to produce the timings in the ZCV paper are included.