-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power spec #108
Power spec #108
Conversation
@lgarrison updating the quick thing for CV, but ran into classy compile issues (and I think the other tests got canceled alongside that). |
There's a workaround for classy on main, can you merge main into this branch? |
Fixing the classy issue
Merged it, but there seems to be some issue now with Corrfunc -- not sure why it only shows up in this branch |
Looks like it was just a transient issue, re-running the jobs fixed it. |
@boryanah In using This did have the side effect of changing the order of the arguments, so just be aware in case you have any code that's using |
Thanks! The default values make sense for |
I wonder if we should switch to passing |
for more information, see https://pre-commit.ci
I was thinking about changing the kbin/mubin arguments too, so I just went ahead and did it. Now they both accept either a number of bins or an array of bins. |
Ok, this looks great to me, so I'll just merge -- thanks. |
Change including TSC offset and minor bugs for LCV