Skip to content

Commit

Permalink
Fix purgeChannel() limit checks (fix #391)
Browse files Browse the repository at this point in the history
Handle decimals properly, handle negative numbers that aren't -1
  • Loading branch information
abalabahaha committed May 26, 2018
1 parent 4e229d5 commit 8ed422b
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions lib/Client.js
Expand Up @@ -1185,6 +1185,9 @@ class Client extends EventEmitter {
if(typeof filter === "string") {
filter = (msg) => msg.content.includes(filter);
}
if(limit !== -1 && limit <= 0) {
Promise.resolve(0);
}
return new Promise((resolve, reject) => {
var toDelete = [];
var deleted = 0;
Expand All @@ -1211,12 +1214,12 @@ class Client extends EventEmitter {
};
var del = (_before, _after) => {
this.getMessages(channelID, 100, _before, _after).then((messages) => {
if(limit === 0) {
if(limit !== -1 && limit <= 0) {
done = true;
return;
}
for(var message of messages) {
if(limit === 0) {
if(limit !== -1 && limit <= 0) {

This comment has been minimized.

Copy link
@Dramex

Dramex Nov 30, 2018

Contributor

this should be back to if(limit === 0)
to solve purgeChannel(-1), becouse limit going to be -2 if it's -1

#438

break;
}
if(message.timestamp < Date.now() - 1209600000) { // 14d * 24h * 60m * 60s * 1000ms
Expand All @@ -1228,7 +1231,7 @@ class Client extends EventEmitter {
}
limit--;
}
if(limit === 0 || messages.length < 100) {
if((limit !== -1 && limit <= 0) || messages.length < 100) {
done = true;
return;
}
Expand Down

0 comments on commit 8ed422b

Please sign in to comment.