Bump nan from 2.17.0 to 2.18.0 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I know the discord.js team has looked into preferring the native zlib module in node but I don't think there's been much progress recently as they don't want to outright switch to it |
Fixes:
```
/root/.cache/node-gyp/21.0.0/include/node/v8-local-handle.h: In instantiation of ‘v8::Local<T>::Local(v8::Local<S>) [with S =
../../nan/nan_callbacks_12_inl.h:175:53: required from here
/root/.cache/node-gyp/21.0.0/include/node/v8-local-handle.h:253:42: error: static assertion failed: type check
253 | static_assert(std::is_base_of<T, S>::value, "type check");
| ^~~~~
make: *** [zlib_sync.target.mk:122: Release/obj.target/zlib_sync/src/zlib_sync.o] Error 1
make: Leaving directory '/home/jam/discordbot/node_modules/zlib-sync/build'
gyp ERR! build error$
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/home/jam/discordbot/node_modules/node-gyp/lib/build.js:203:23)
gyp ERR! stack at ChildProcess.emit (node:events:515:28)
gyp ERR! stack at ChildProcess._handle.onexit (node:internal/child_process:294:12)
gyp ERR! System Linux 5.4.0-153-generic
gyp ERR! command "/root/.nvm/versions/node/v21.0.0/bin/node" "/home/jam/discordbot/node_modules/node-gyp/bin/node-gyp.js" "re
gyp ERR! cwd /home/jam/discordbot/node_modules/zlib-sync
gyp ERR! node -v v21.0.0
gyp ERR! node-gyp -v v9.4.0
gyp ERR! not ok$
```
Similar issue to #9 after NodeJS 21 v8 Upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Similar issue to #9 after NodeJS 21 v8 Upgrade