-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.9.2-19 not discovering all peripherals #296
Comments
@Apollon77, have you noticed this at all? I have users reporting also. |
I hear that the first time. I more hot Reports that Servicedata fills up. Ore and more over time and so used cpu more and more. Maybe the idea is to Use debug logs ('DEBUG=noble,hci,att,gap node ....' and generate it for both Versions and then compare. Maybe we see something. |
Hmm the issue you mentioned could be related. It seems to happen with these Miflora devices: From -19 version:
And the service data slowly duplicates to this:
on -15 this is normal and looks like this:
In my logic I'm always finding the service data with the uid like const xiaomiService = peripheral.advertisement.serviceData.find((service) => service.uuid === XiaomiServiceId); So i'm always getting the first one which is the same as the rest of the advertisements get infinitely appended to the serviceData array and not broadcasted as individual values as in -15 version 🤔 These sensors work in way that they broadcast multiple different advertisements always with the same serviceData uuid one at the time and in the data by parsing it one can figure out what type of sensor it is. So this seems to be the root issue 👍 |
Also why this does not happen with my ruuvitag devices is probably because they broadcast their values in the manufacturer data not service one:
😅 |
@Apollon77 I think I managed to find the source of the problem #297 |
Cool. Will review as soon as Kids in bed. @AlCalzone maybe interesting!! |
Ps: does that also fix your discovery issue? |
Yeah 👍 My own discovery logic broke as the new service data just got appended to the array as my code expected it to be unique one entry by id 😁 |
solved in #297 |
Hi 👋 and thanks for maintaining this fork! I updated my project for -19 from -15 release and noticed that some of my ble advertisements aren't discovered anymore by noble. Meaning I'm just not seeing them from:
Downgrading to -15 fixes this.
These peripherals in question are Xiaomi miflora devices (plant sensors), all my ruuvitags (temperature sensors from a different brand) are still discovered as usual so I'm lead to believe it's something to do with those advertisements particular. On the surface level though I cannot see anything special how these devices advertise:
Some other background info:
I'm happy to debug deeper, I'm not just so familiar where to start 😅. I noticed there was a lot of changes between -15 and -19 so I could not on a quick look figure out anything meaningful from the changes either. Thanks a lot!
The text was updated successfully, but these errors were encountered: