add hook, change hook location and change private $error to public $error #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror I change the private $error to public $error in the checkout/address as i found out that i cannot add additional error message from our extension. As for the checkout/confirm.tpl, i moved the hook due to i put the hook in the wrong location.
…ng template I added _title and _text within the label for as there are no way to know which one was the title and the price.
abolabo
requested changes
May 4, 2021
...tml/extensions/fast_checkout/storefront/view/default/template/responses/checkout/payment.tpl
Outdated
Show resolved
Hide resolved
I found out that in sale/order_invoice the product id was not set so i change the hook in the order_invoice.tpl to use product name instead of product id.
I confirm that your suggestion on adding additional data behind the telephone works
I remove the additional "_title" and "_text" from the label and add label id
I remove the additional "_title" and "_text" from the label for and add label id
I remove the additional "_title" and "_text" from the label for and add label id
add additional hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I change the private $error to public $error in the checkout/address as i found out that i cannot add additional error message from our extension.
As for the checkout/confirm.tpl, i moved the hook due to i put the hook in the wrong location.