Skip to content
This repository has been archived by the owner on Dec 17, 2023. It is now read-only.

Add bal msgty metric #114

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Add bal msgty metric #114

merged 3 commits into from
Jan 28, 2021

Conversation

Goala
Copy link
Member

@Goala Goala commented Jan 27, 2021

closes #113

@JohannesKonings
Copy link
Member

@Goala could you maybe correct the docs with this pull request :)
The BAL section has the wrong title
https://github.com/abap-observability-tools/abap-metrics-provider/blob/main/docs/README.md#transport-states-bal

@Goala
Copy link
Member Author

Goala commented Jan 27, 2021

@JohannesKonings sure

@Goala Goala changed the title Add bal msgty metric Draft: Add bal msgty metric Jan 27, 2021
@Goala Goala marked this pull request as draft January 27, 2021 15:29
@Goala Goala changed the title Draft: Add bal msgty metric Add bal msgty metric Jan 27, 2021
@Goala Goala marked this pull request as ready for review January 28, 2021 11:08
JohannesKonings
JohannesKonings approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@JohannesKonings JohannesKonings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohannesKonings JohannesKonings merged commit ca98677 into abap-observability-tools:main Jan 28, 2021
@Goala Goala deleted the add-bal-msgty-metric branch January 28, 2021 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JohannesKonings JohannesKonings JohannesKonings approved these changes

@sinkduk sinkduk Awaiting requested review from sinkduk

@ThoralfHaensel ThoralfHaensel Awaiting requested review from ThoralfHaensel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add msgty to bal metrics
2 participants
@Goala @JohannesKonings