You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A lot of methos have parameters that are typed very specifically. On various occasions this struck me as overly difficult to use.
Example ( See demoreport 1 )
DATA: width TYPE i VALUE 11.
column_dimension->set_width( ip_width = width ).
Solution: Change the typing of parameters to more general generic types to allow for easier use and convert to preferred type on entry of the method.
Examples which come to my mind.
column_dimension->set_width: ip_width : set to TYPE ANY ( to support NUMC-fields as well ) - raise exception if something really unsuitable gets passed
row_dimension->set_row_height: ip_height : set to TYPE ANY ( to support NUMC-fields as well ) - raise exception if something really unsuitable gets passed
various_methods: ip_column ( usually typed to ZEXCEL_CELL_COLUMN_ALPHA ). Set to TYPE ANY ( to support numerical access to a column as well ) raise exception if something really unsuitable gets passed
The text was updated successfully, but these errors were encountered:
Starting this issue ( using less strict typing and adding exceptions if something really strange gets passed ):
ZCL_EXCEL_COMMON->CONVERT_COLUMN2INT
ZCL_EXCEL_WORKSHEET_COLUMNDIME->SET_WIDTH
ZCL_EXCEL_WORKSHEET_ROWDIMENSI->SET_ROW_HEIGHT
Switched parameter ip_column in the following methods from ZEXCEL_CELL_COLUMN_ALPHA to SIMPLE and added exceptionclass ZCX_EXCEL where this wasn't present at the time being. Mainly this was done to allow using numeric access to columns. Probably I'll change the latest demoprogram ( static styles - Chess ) because there it will ease up code.
A lot of methos have parameters that are typed very specifically. On various occasions this struck me as overly difficult to use.
Example ( See demoreport 1 )
The following code does work
This won't, bécaule ip_width is typed as "Float"
Solution: Change the typing of parameters to more general generic types to allow for easier use and convert to preferred type on entry of the method.
Examples which come to my mind.
column_dimension->set_width: ip_width : set to TYPE ANY ( to support NUMC-fields as well ) - raise exception if something really unsuitable gets passed
row_dimension->set_row_height: ip_height : set to TYPE ANY ( to support NUMC-fields as well ) - raise exception if something really unsuitable gets passed
various_methods: ip_column ( usually typed to ZEXCEL_CELL_COLUMN_ALPHA ). Set to TYPE ANY ( to support numerical access to a column as well ) raise exception if something really unsuitable gets passed
The text was updated successfully, but these errors were encountered: