Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data validations do not show error for invalid values when used whith BIND_TABLE #71

Closed
ivanfemia opened this issue Dec 27, 2013 · 3 comments
Milestone

Comments

@ivanfemia
Copy link
Collaborator

I use the Demo Report ZDEMO_EXCEL9 to create a Excel Document with data validation. The validation is displayed as a Drop-Down List. When I try to enter a value that is not in this list, then Excel shows an error message and I have to adjust my change. But when I add such a data validation to fields of a table created with the BIND_TABLE method of the ZCL_EXCEL_WORKSHEET class, then Excel does not show an error when a non valid value is entered. I've adjusted ZDEMO_EXCEL3 to illustrate this problem and attached it's output to this issue. The adjusted version of ZDEMO_EXCEL3 can be found in the latest commit.

@ivanfemia
Copy link
Collaborator Author

Hi Gregor,

What version of Excel are you using?
I cannot reproduce it on my installation.

@ivanfemia
Copy link
Collaborator Author

This issue is not valid anymore.
In the file you attached to this issue Excel works as expected: in cell C4 there is a validation with 'Ignore blanks' flag and 'Airlines' range. This range is to wide - contains one empty cell at the end. In such case Excel allows any value to be entered.

This issue was fixed meanwhile by you change in revision 143. You set different value for the property "allowBlank" in the constructor of ZCL_EXCEL_DATA_VALIDATION so now Excel shows an error.

You can see the difference in the sheet attached to this issue - if you flip the flag or change Airlines range to exclude empty cell validation will work.

BTW, I suggest updating ZDEMO_EXCEL3 to set Airlines range to 'row - 1' and not 'row'.

@ivanfemia
Copy link
Collaborator Author

[[file:cvivHadcKr473dacwqjQYw]]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant