Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update abapGit-installation.md #1001

Merged
merged 4 commits into from Mar 12, 2022

Conversation

AndreaBorgia-Abo
Copy link
Member

naming suggestions for demos package and explanation

naming suggestions for demos package and explanation
@AndreaBorgia-Abo AndreaBorgia-Abo marked this pull request as draft March 12, 2022 10:34
@AndreaBorgia-Abo
Copy link
Member Author

AndreaBorgia-Abo commented Mar 12, 2022

Back to draft to fix a typo and, also, to force abaplint checks to restart (somehow it got stuck)
@larshp any tips?

@AndreaBorgia-Abo AndreaBorgia-Abo marked this pull request as ready for review March 12, 2022 10:36
@AndreaBorgia-Abo AndreaBorgia-Abo requested review from larshp and removed request for sandraros March 12, 2022 10:57
@larshp
Copy link
Member

larshp commented Mar 12, 2022

push another commit, abaplint was down, see https://status.abaplint.app (Kubernetes argh 😠 )

@larshp
Copy link
Member

larshp commented Mar 12, 2022

updated, results as expected 😄

recommend that demos be created as local package
Copy link
Member Author

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added suggested changes

Copy link
Member

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@larshp larshp merged commit ac8f4a7 into abap2xlsx:master Mar 12, 2022
@AndreaBorgia-Abo
Copy link
Member Author

Followup notes for @larshp : when squashing multiple commits, feel free to edit the logs accordingly.
For example in this case the logs could have been shortened to this:

* Update abapGit-installation.md
naming suggestions for demos package and explanation
recommend that demos be created as local package

@AndreaBorgia-Abo AndreaBorgia-Abo deleted the demo-_docs_warning branch March 13, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants