Fix issue 1013 part1 #1039
Open
Fix issue 1013 part1 #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
| @@ -524,8 +524,10 @@ CLASS zcl_excel_converter IMPLEMENTATION. | |||
| METHOD create_color_style. | |||
| DATA: ls_styles TYPE ts_styles. | |||
| DATA: lo_style TYPE REF TO zcl_excel_style. | |||
|
|
|||
| READ TABLE wt_styles INTO ls_styles WITH KEY guid = i_style. | |||
| * Begin of ATC fix-issue-1014-part1 | |||
There was a problem hiding this comment.
It's better to remove unused code, rather than commenting it out, and there is no need for comments pointing to issues and fixes, since git already takes care of that.
|
I guess the fix concerns #1013 (not 1014), so I fixed the title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.