Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endless loop in bind_table #1044

Merged
merged 3 commits into from Jul 13, 2022
Merged

endless loop in bind_table #1044

merged 3 commits into from Jul 13, 2022

Conversation

sandraros
Copy link
Collaborator

Fix #1043

@AndreaBorgia-Abo
Copy link
Member

On it! While I test this, fancy looking at that date/time format PR?

AndreaBorgia-Abo
AndreaBorgia-Abo requested changes Jul 11, 2022
View reviewed changes
src/zcl_excel_worksheet.clas.abap Show resolved Hide resolved
src/zcl_excel_worksheet.clas.abap Outdated Show resolved Hide resolved
AndreaBorgia-Abo
AndreaBorgia-Abo approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, it works nicely and looks readable!
Here are the relevant transitions:

Text Text Text Text Text Text Text Tex 9
Text Text Text Text Text Text Text Tex10
Text Text Text Text Text Text Text Tex99
Text Text Text Text Text Text Text Te100

LGTM!

@AndreaBorgia-Abo AndreaBorgia-Abo merged commit 11b47ec into main Jul 13, 2022
@AndreaBorgia-Abo AndreaBorgia-Abo deleted the sandraros/endless-loop branch July 13, 2022 18:28
@sandraros
Copy link
Collaborator Author

@AndreaBorgia-Abo Thanks a lot for suggestions and fast review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreaBorgia-Abo AndreaBorgia-Abo AndreaBorgia-Abo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excel file creation takes extremely long time
2 participants
@sandraros @AndreaBorgia-Abo