Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 7.16.0 #1053

Merged
merged 2 commits into from Aug 13, 2022
Merged

Release 7.16.0 #1053

merged 2 commits into from Aug 13, 2022

Conversation

AndreaBorgia-Abo
Copy link
Member

The 7.16.0 tag shows up in my repo for the release branch, I don't know how to check if it is included in the PR.

@sandraros
Copy link
Collaborator

Could you add the tag via Git console (or try to use abapGit, there's the feature Tag > Create, not sure if it's the same as the GitHub way), so that we can later make it appear in the home page?
image

@sandraros
Copy link
Collaborator

Sorry, I realize that my question was answered in your initial comment. I guess we can see using a Git client. Let's merge, we'll see.

@sandraros sandraros merged commit ef47a72 into abap2xlsx:main Aug 13, 2022
@AndreaBorgia-Abo
Copy link
Member Author

Well, I guess the tag only shows in the branch where it was added and it appears that it is not carried over with a PR;
I'll add a new one in this repo now and edit the instructions after releasing.

@AndreaBorgia-Abo
Copy link
Member Author

also, GH recommends using "v" as first letter of release-related tags, which makes sense: I had to rename my branch from "7.16.0" to "branch-7.16.0" because git was complaining about ambiguous references since 7.16.0 could be either a tag or a branch.
I will check whether older tags can be renamed without too much breakage and then edit the guideline accordingly.

@AndreaBorgia-Abo
Copy link
Member Author

AndreaBorgia-Abo commented Aug 13, 2022

For future reference, this is what I did:

  • checked whether tags are annotated or lightweight: older tags by Ivan where annotated, newer tags are lightweight
  • renamed tags, new ones are lightweight
  • navigated from old 7.14.0 and 7.15.0 release links and edited them to point to the new v7.14.0 and v7.15.0 tags, so the existing releases show up pointing to the new tags
  • edited the checklist with naming suggestions

TLDR if you have a local clone of the project, run git pull --prune --tags

@AndreaBorgia-Abo AndreaBorgia-Abo deleted the branch-7.16.0 branch August 13, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants