Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUnit warning zcl excel reader huge file "# au > "#au #739 #742

Conversation

sandraros
Copy link
Collaborator

Fix Useless warning in ABAP Unit tests of ZCL_EXCEL_READER_HUGE_FILE (reason: extra space "# AU -> "#AU) #739

sandraros and others added 2 commits February 11, 2021 21:14
Pull latest abap2xlsx changes
Useless warning in ABAP Unit tests of ZCL_EXCEL_READER_HUGE_FILE (reason: extra space "# AU -> "#AU) abap2xlsx#739
@larshp
Copy link
Member

larshp commented Feb 21, 2021

the pseudo comments,
" #AU Risk_Level Harmless
and class
cl_aunit_assert
are both obsolete

suggest changing it to the newer syntax, https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapclass_for_testing.htm

Copy link
Member

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good to me 👍

@larshp larshp merged commit a0e2349 into abap2xlsx:master Feb 21, 2021
sandraros added a commit to sandraros/abap2xlsx that referenced this pull request Feb 27, 2021
AUnit warning zcl excel reader huge file "# au  > "#au abap2xlsx#739 (abap2xlsx#742)
@sandraros sandraros deleted the AUnit-warning-ZCL_EXCEL_READER_HUGE_FILE-"#-AU-->-"#AU-#739 branch September 21, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants