Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

# Huge writer error height/hight and fit to page #912

Merged
merged 1 commit into from Dec 11, 2021
Merged

# Huge writer error height/hight and fit to page #912

merged 1 commit into from Dec 11, 2021

Conversation

sandraros
Copy link
Collaborator

@sandraros sandraros commented Dec 10, 2021 •
edited

Fix #553 and also "fit to page" which didn't work at all.

AndreaBorgia-Abo
AndreaBorgia-Abo approved these changes Dec 11, 2021
View reviewed changes
Copy link
Member

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified transformation before and after, change makes sense.
The test program demonostrates the issue before merging and works fine afterwards, LGTM.

@AndreaBorgia-Abo AndreaBorgia-Abo merged commit 6ffcba1 into master Dec 11, 2021
@AndreaBorgia-Abo AndreaBorgia-Abo deleted the sandraros/huge-writer-transfo-hight branch December 11, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreaBorgia-Abo AndreaBorgia-Abo AndreaBorgia-Abo approved these changes

@bigld bigld Awaiting requested review from bigld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dump when calling Transformation zexcel_tr_sheet
2 participants
@sandraros @AndreaBorgia-Abo