Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo: hasehd -> hashed #927

Merged
merged 4 commits into from Dec 24, 2021

Conversation

AndreaBorgia-Abo
Copy link
Member

No functional changes, fixed a typo to have consistent naming

Copy link
Member Author

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are as expected

@sandraros
Copy link
Collaborator

I'm afraid of changing any public member, but I think it's acceptable here because this type is only used privately. Would you mind making all these types private too? (I couldn't suggest the changes, but it'll be feasible soon) Thanks!

Copy link
Member Author

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types are now private

@sandraros sandraros merged commit c55cf52 into abap2xlsx:master Dec 24, 2021
@AndreaBorgia-Abo AndreaBorgia-Abo deleted the fix-hasehd-typo branch December 24, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants