Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip_style TYPE any + add_new_style( io_clone_of = ) #929

Merged
merged 8 commits into from Jan 9, 2022

Conversation

sandraros
Copy link
Collaborator

Permits code footprint reduction as described in #524

@sandraros sandraros marked this pull request as ready for review January 6, 2022 19:30
Copy link
Member

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of comments we might want to update
(I checked that the numbers match)

src/demos/zdemo_excel2.prog.abap Outdated Show resolved Hide resolved
src/demos/zdemo_excel2.prog.abap Outdated Show resolved Hide resolved
Copy link
Member

@AndreaBorgia-Abo AndreaBorgia-Abo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreaBorgia-Abo AndreaBorgia-Abo merged commit 7fa137b into master Jan 9, 2022
@AndreaBorgia-Abo AndreaBorgia-Abo deleted the sandraros/codefootprint-style branch January 9, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants