Read XLSX from third-party providers (namespaces) #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(the change is moved to dedicated PR #939)
|
I used this tool to create Excel files with changed namespace prefixes, then running |
AndreaBorgia-Abo
approved these changes
Jan 15, 2022
There was a problem hiding this comment.
Assuming my eyes are not now permanently crossed :) I'd say this LGTM.
I have used the XSLT rename tool with the HelloWord example and verified that the updated code can read both this new file and the original sample attached to the bug report, whereas the prevoious code could not.
AndreaBorgia-Abo
added a commit
that referenced
this pull request
Jan 15, 2022
* Fix demo programs 3 and 33 * updated reader reference files ( affected by #935 ) Co-authored-by: sandraros <sandra.rossi@gmail.com> Co-authored-by: Lars Hvam <larshp@hotmail.com> Co-authored-by: Abo <andrea@borgia.bo.it>
|
Thanks. Well done, this one was not easy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #447