Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to use new collection classes #937

Merged
merged 19 commits into from Jan 1, 2022
Merged

refactor to use new collection classes #937

merged 19 commits into from Jan 1, 2022

Conversation

larshp
Copy link
Member

@larshp larshp commented Dec 29, 2021

closes #880

@sandraros sandraros self-assigned this Dec 31, 2021
sandraros
sandraros requested changes Dec 31, 2021
View reviewed changes
Copy link
Collaborator

@sandraros sandraros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but class names in CLASS IMPLEMENTATION are all changed to upper case. Is it normal?

@larshp
Copy link
Member Author

larshp commented Jan 1, 2022

its changed by SE80,

if you'd like to enforce a specific style, suggest enabling https://rules.abaplint.org/keyword_case/, https://github.com/abap2xlsx/abap2xlsx/blob/master/abaplint.json#L109

@sandraros sandraros mentioned this pull request Jan 1, 2022
Closed
sandraros
sandraros requested changes Jan 1, 2022
View reviewed changes
Copy link
Collaborator

@sandraros sandraros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing back to CLASS zcl_<alllowercase> IMPLEMENTATION. Proposed lint rule in #941.

src/zcl_excel.clas.abap Outdated Show resolved Hide resolved
src/zcl_excel_columns.clas.abap Outdated Show resolved Hide resolved
src/zcl_excel_comments.clas.abap Outdated Show resolved Hide resolved
src/zcl_excel_data_validations.clas.abap Outdated Show resolved Hide resolved
src/zcl_excel_drawings.clas.abap Outdated Show resolved Hide resolved
src/zcl_excel_worksheets.clas.abap Outdated Show resolved Hide resolved
src/zcl_excel_writer_csv.clas.abap Outdated Show resolved Hide resolved
src/zcl_excel_writer_huge_file.clas.abap Outdated Show resolved Hide resolved
src/zcl_excel_writer_xlsm.clas.abap Outdated Show resolved Hide resolved
src/zcl_excel_writer_2007.clas.abap Outdated Show resolved Hide resolved
larshp and others added 17 commits January 1, 2022 11:53
@larshp @sandraros
Update src/zcl_excel.clas.abap
2af6350 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_comments.clas.abap
712631e 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_data_validations.clas.abap
3c3cea6 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_drawings.clas.abap
df215b8 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_worksheets.clas.abap
4e5f453 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_writer_csv.clas.abap
6215b45 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_writer_huge_file.clas.abap
2bf2ad6 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_writer_xlsm.clas.abap
f0dbb01 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_writer_2007.clas.abap
465375c 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_columns.clas.abap
425490b 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_fill_template.clas.abap
0763bf9 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_worksheet.clas.abap
944262f 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_ranges.clas.abap
f320795 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_reader_2007.clas.abap
d916fd3 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_rows.clas.abap
89929d0 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_styles.clas.abap
f5a6396 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@larshp @sandraros
Update src/zcl_excel_styles_cond.clas.abap
54f17bd 
Co-authored-by: sandraros <34005250+sandraros@users.noreply.github.com>
@sandraros sandraros closed this Jan 1, 2022
@sandraros sandraros deleted the hvam/collection2 branch January 1, 2022 11:38
@sandraros sandraros restored the hvam/collection2 branch January 1, 2022 11:39
@larshp
Copy link
Member Author

larshp commented Jan 1, 2022

reopen?

@larshp larshp reopened this Jan 1, 2022
@sandraros sandraros merged commit 98d6765 into master Jan 1, 2022
@sandraros sandraros deleted the hvam/collection2 branch January 1, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandraros sandraros sandraros requested changes

Assignees

@sandraros sandraros

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactoring: use of cl_object_collection_iterator
2 participants
@larshp @sandraros