Delete objects moved to abap2xlsx/demos repository #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreaBorgia-Abo
approved these changes
Mar 6, 2022
There was a problem hiding this comment.
LGTM
One question, though: the linter complaints are due to the move, right?
|
I didn't see that. I have added |
AndreaBorgia-Abo
deleted the
sandraros/delete-objects-moved-to-demos-repo
branch
This was referenced Mar 8, 2022
Closed
|
@sandraros do we want to move the W3MI objects as well? This is not needed for the abapGit issue but the subpackage is not otherwise used. |
|
@AndreaBorgia-Abo Oh yes, sure, I forgot them! |
|
Moving season.... PRs incoming.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #861, proposing to remove the demo programs from the main repository. I have just created the repository https://github.com/abap2xlsx/demos with all the demo programs. Hopefully it will also solve #993 (complex issue related to abapGit way of pulling and combination of DDIC, programs, classes and transformations).