Skip to content

Commit

Permalink
GUI for calling syntax check #911
Browse files Browse the repository at this point in the history
  • Loading branch information
larshp committed Oct 1, 2017
1 parent 9786e76 commit a43d4df
Show file tree
Hide file tree
Showing 6 changed files with 90 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/zabapgit_definitions.prog.abap
Expand Up @@ -214,6 +214,7 @@ INTERFACE lif_defs.
repo_refresh_checksums TYPE string VALUE 'repo_refresh_checksums',
repo_toggle_fav TYPE string VALUE 'repo_toggle_fav',
repo_transport_to_branch TYPE string VALUE 'repo_transport_to_branch',
repo_syntax_check TYPE string VALUE 'repo_syntax_check',

abapgit_home TYPE string VALUE 'abapgit_home',
abapgit_wiki TYPE string VALUE 'abapgit_wiki',
Expand Down
1 change: 1 addition & 0 deletions src/zabapgit_gui_pages.prog.abap
Expand Up @@ -30,3 +30,4 @@ INCLUDE zabapgit_page_stage.
INCLUDE zabapgit_page_debug.
INCLUDE zabapgit_page_settings.
INCLUDE zabapgit_page_repo_settings.
INCLUDE zabapgit_page_syntax_check.
5 changes: 5 additions & 0 deletions src/zabapgit_gui_router.prog.abap
Expand Up @@ -163,6 +163,11 @@ CLASS lcl_gui_router IMPLEMENTATION.
WHEN lif_defs=>gc_action-repo_refresh. " Repo refresh
lcl_services_repo=>refresh( lv_key ).
ev_state = lif_defs=>gc_event_state-re_render.
WHEN lif_defs=>gc_action-repo_syntax_check.
CREATE OBJECT ei_page TYPE lcl_gui_page_syntax_check
EXPORTING
io_repo = lcl_app=>repo_srv( )->get( lv_key ).
ev_state = lif_defs=>gc_event_state-new_page.
WHEN lif_defs=>gc_action-repo_purge. " Repo remove & purge all objects
lcl_services_repo=>purge( lv_key ).
ev_state = lif_defs=>gc_event_state-re_render.
Expand Down
59 changes: 59 additions & 0 deletions src/zabapgit_page_syntax_check.prog.abap
@@ -0,0 +1,59 @@
*&---------------------------------------------------------------------*
*& Include ZABAPGIT_PAGE_SYNTAX_CHECK
*&---------------------------------------------------------------------*

*&---------------------------------------------------------------------*
*& Include ZABAPGIT_PAGE_REPO_SETTINGS
*&---------------------------------------------------------------------*

CLASS lcl_gui_page_syntax_check DEFINITION FINAL INHERITING FROM lcl_gui_page.
PUBLIC SECTION.
METHODS:
constructor
IMPORTING io_repo TYPE REF TO lcl_repo.

PROTECTED SECTION.
CONSTANTS:
BEGIN OF c_action,
back TYPE string VALUE 'back',
END OF c_action.

DATA: mo_repo TYPE REF TO lcl_repo.

METHODS:
render_content REDEFINITION.

ENDCLASS.

CLASS lcl_gui_page_syntax_check IMPLEMENTATION.

METHOD constructor.
super->constructor( ).
ms_control-page_title = 'SYNTAX CHECK'.
mo_repo = io_repo.
ENDMETHOD. " constructor.

METHOD render_content.

DATA: lt_result TYPE scit_alvlist,
ls_result LIKE LINE OF lt_result.


lt_result = zcl_abapgit_syntax_check=>run( mo_repo->get_package( ) ).

CREATE OBJECT ro_html.
ro_html->add( '<div class="toc">' ).

IF lines( lt_result ) = 0.
ro_html->add( 'No errors' ).
ENDIF.

LOOP AT lt_result INTO ls_result.
ro_html->add( |{ ls_result-objtype } { ls_result-objname } { ls_result-kind } { ls_result-text }<br>| ).
ENDLOOP.

ro_html->add( '</div>' ).

ENDMETHOD. "render_content

ENDCLASS. "lcl_gui_page_debuginfo
22 changes: 22 additions & 0 deletions src/zabapgit_page_syntax_check.prog.xml
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="utf-8"?>
<abapGit version="v1.0.0" serializer="LCL_OBJECT_PROG" serializer_version="v1.0.0">
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<PROGDIR>
<NAME>ZABAPGIT_PAGE_SYNTAX_CHECK</NAME>
<STATE>A</STATE>
<VARCL>X</VARCL>
<SUBC>I</SUBC>
<RLOAD>E</RLOAD>
<UCCHECK>X</UCCHECK>
</PROGDIR>
<TPOOL>
<item>
<ID>R</ID>
<ENTRY>Include ZABAPGIT_PAGE_SYNTAX_CHECK</ENTRY>
<LENGTH>34</LENGTH>
</item>
</TPOOL>
</asx:values>
</asx:abap>
</abapGit>
2 changes: 2 additions & 0 deletions src/zabapgit_view_repo.prog.abap
Expand Up @@ -314,6 +314,8 @@ CLASS lcl_gui_view_repo IMPLEMENTATION.
lo_tb_advanced->add( iv_txt = 'Make on-line'
iv_act = |{ lif_defs=>gc_action-repo_remote_attach }?{ lv_key }| ).
ENDIF.
lo_tb_advanced->add( iv_txt = 'Syntax Check'
iv_act = |{ lif_defs=>gc_action-repo_syntax_check }?{ lv_key }| ).
lo_tb_advanced->add( iv_txt = 'Repo settings'
iv_act = |{ lif_defs=>gc_action-repo_settings }?{ lv_key }| ).
lo_tb_advanced->add( iv_txt = 'Update local checksums'
Expand Down

0 comments on commit a43d4df

Please sign in to comment.