Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminology - Because it's the right thing to do... #4043

Closed
6 tasks done
mbtools opened this issue Oct 17, 2020 · 6 comments · Fixed by #4791
Closed
6 tasks done

Terminology - Because it's the right thing to do... #4043

mbtools opened this issue Oct 17, 2020 · 6 comments · Fixed by #4791
Assignees
@mbtools
Labels
good first issue Want to help out with something small?

Comments

@mbtools
Copy link
Member

mbtools commented Oct 17, 2020 •
edited

Replacing racially insensitive language in abapGit

Current Suggested Change
User Master Record User Record
Master Language Main Language
Master Branch Main Branch

Priority:

  1. UI texts & documentation
  2. Object and variable names in coding

References:
https://help.sap.com/doc/b0322267728e48a28b0c8ee7dd1ab4c7/1.0/en-US/Inclusive%20Language%20Guidelines.pdf
https://www.zdnet.com/article/github-to-replace-master-with-alternative-term-to-avoid-slavery-references/

To-do:

  • User Master Record > User Record
  • Master Language > Main Language (UI, comments, docs)
  • Master Language > Main Language (variables/parameters)
  • Master Branch > Main Branch (UI, comments, docs)
  • Master Branch > Main Branch (variables/parameters)
  • Docs (screenshots)

PS: I found no references to "slave", "black", or "white".
@mbtools mbtools added the good first issue Want to help out with something small? label Oct 17, 2020
@larshp larshp changed the title Because it's the right thing to do... Terminology - Because it's the right thing to do... Oct 18, 2020
@larshp
Copy link
Member

larshp commented Oct 18, 2020

Note, according to link below, github will provide a feature for seamless rename of default branch,
https://github.com/github/renaming#later-this-year-seamless-move-for-existing-repositories-
so for abapGit itself, suggest awaiting this feature before renaming master to main

@mbtools
Copy link
Member Author

mbtools commented Nov 10, 2020

#4158, #4159

mbtools added a commit that referenced this issue Jan 18, 2021
@mbtools
Refactor I18N settings
67a3797 
- Consolidate I18N parameters into a structure and pass it to xml and serializer classes (#4415)
- Continue change of terminology (#4043)
This was referenced Jan 18, 2021
Merged
Merged
larshp added a commit that referenced this issue Jan 19, 2021
@mbtools @larshp
Refactor I18N settings (#4423)
31a550d 
* Refactor I18N settings

- Consolidate I18N parameters into a structure and pass it to xml and serializer classes (#4415)
- Continue change of terminology (#4043)

* Remove changes to serializer class

* Main lang

* DSYS

* OTGR

* Repo view

* Main langu

* Repo view %26 stage

* Serialize

* Settings

* Repo view

* Defs

* Stage

Co-authored-by: Lars Hvam <larshp@hotmail.com>
@larshp
Copy link
Member

larshp commented Jan 19, 2021

renaming branches, https://github.blog/changelog/2021-01-19-support-for-renaming-an-existing-branch/, I'll probably test it on a few other repos before abapGit

@mbtools
Copy link
Member Author

mbtools commented Jan 19, 2021

Agree, let a few others covert their repo branches first

mbtools added a commit that referenced this issue Jan 21, 2021
@mbtools
Terminology: Inclusive Language - Part 4
70239fd 
Continue change of terminology (#4043)
@mbtools mbtools mentioned this issue Jan 21, 2021
Merged
larshp added a commit that referenced this issue Jan 21, 2021
@mbtools @larshp
Terminology: Inclusive Language - Part 4 (#4432)
978b7a4 
* Terminology: Inclusive Language - Part 4

Continue change of terminology (#4043)

* Service

* Language

Co-authored-by: Lars Hvam <larshp@hotmail.com>
mbtools added a commit that referenced this issue Jan 22, 2021
@mbtools
Terminology: Inclusive Language - Part 4b
726661e 
Change of terminology (#4043). This time with the missing changes in service_repo.

repo_srv and serializer will be next after #4431.
@mbtools mbtools mentioned this issue Jan 22, 2021
Merged
larshp added a commit that referenced this issue Jan 23, 2021
@mbtools @larshp
Terminology: Inclusive Language - Part 4b (#4436)
6d35640 
Change of terminology (#4043). This time with the missing changes in service_repo.

repo_srv and serializer will be next after #4431.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
@larshp
Copy link
Member

larshp commented Feb 28, 2021

I've renamed the default branch for most abapGit organization repos,

todo, need to coordinate,
https://github.com/abapGit/eclipse.abapgit.org
https://github.com/abapGit/ADT_Frontend

@larshp larshp mentioned this issue Feb 28, 2021
Merged
@larshp
Copy link
Member

larshp commented Feb 28, 2021

default branches in organization https://github.com/abapGit-tests renamed for all repos

mbtools added a commit that referenced this issue Apr 14, 2021
@mbtools
Terminology: Inclusive Language - Part 5
5a9f7d1 
Change of terminology (#4043)

- Replace `get_master_language` with `get_main_language` and remove it
@mbtools mbtools mentioned this issue Apr 14, 2021
Merged
larshp pushed a commit that referenced this issue Apr 15, 2021
@mbtools
Terminology: Inclusive Language - Part 5 (#4702)
f18a8ee 
* Terminology: Inclusive Language - Part 5

Change of terminology (#4043)

- Replace `get_master_language` with `get_main_language` and remove it

* File Status

* Jump

* Language

* Main language

* Main language
mbtools added a commit that referenced this issue May 25, 2021
@mbtools
Terminology: Inclusive Language - Part 6
f53a07f 
Change remaining variables and switch setting to main_language. 

Finally closes #4043
@mbtools mbtools mentioned this issue May 25, 2021
Merged
larshp added a commit that referenced this issue May 28, 2021
@mbtools @larshp
Terminology: Inclusive Language - Part 6 (#4791)
ad244ab 
* Terminology: Inclusive Language - Part 6

Change remaining variables and switch setting to main_language. 

Finally closes #4043

* Add todo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbtools mbtools

Labels
good first issue Want to help out with something small?
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Terminology: Inclusive Language - Part 6 abapGit/abapGit
2 participants
@larshp @mbtools